Set Serial Clockrate based on data parsed from host firmware#6215
Merged
mergify[bot] merged 2 commits intotianocore:masterfrom Sep 20, 2024
Merged
Set Serial Clockrate based on data parsed from host firmware#6215mergify[bot] merged 2 commits intotianocore:masterfrom
mergify[bot] merged 2 commits intotianocore:masterfrom
Conversation
tianocore-assign-reviewers
bot
requested review from
LiuZhiguang001,
Sean-StarLabs,
gdong1,
gguo11837463,
jameslu8 and
lgao4
vbpandya
reviewed
Sep 18, 2024
Contributor
vbpandya
left a comment
vbpandya
left a comment
There was a problem hiding this comment.
stating the obvious caught by CI :)
"WARNING - Line 3 of commit message is too long (76 >= 76)"
MrChromebox
force-pushed
the
set_serial
branch
3 times, most recently
from
d05a6e5 to
bcb953e
Compare
Sean-StarLabs
approved these changes
Sep 18, 2024
vbpandya
approved these changes
Sep 18, 2024
Contributor
|
Before make this change, please make sure this document got update. Source Code should be change like below. |
Contributor
Author
|
@gguo11837463 have opened a PR to update the documentation here: Will update this PR to only use the ClockRate if header version >= 2. |
MrChromebox
force-pushed
the
set_serial
branch
from
bcb953e to
b6b5afe
Compare
MrChromebox
changed the title
ChaselChiu
reviewed
Sep 19, 2024
MrChromebox
force-pushed
the
set_serial
branch
from
b6b5afe to
b2a3c40
Compare
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
MrChromebox
force-pushed
the
set_serial
branch
from
b2a3c40 to
f60437b
Compare
ChaselChiu
approved these changes
Sep 19, 2024
gguo11837463
approved these changes
Sep 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Set PcdSerialClockRate from SerialPortInfo in UefiPayloadEntry.
The initial approach was to add a ClockRate field to UNIVERSAL_PAYLOAD_SERIAL_PORT_INFO data struct, but simplified to setting the PCD directly based on feedback from reviewers.
These changes enable the serial clock rate value, which is already passed in from the host firmware, to be used when configuring the serial port for debug output. AMD Zen platform devices require this in order to have functional serial output.
How This Was Tested
build/boot multiple AMD/Intel devices and verify serial output works for all.
Integration Instructions
N/A